Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split redis codec #1051

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Split redis codec #1051

merged 4 commits into from
Feb 21, 2023

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 20, 2023

  • the redis codec is now split into builder, encoder and decoder
  • shotover-proxy/src/transforms/redis/sink_single.rs took a bit of fiddling with types as we now need to apply the codecs to the streams after splitting instead of before.
  • fn redis_query_type is moved into a new frame/redis.rs module, as it is not related to the codec at all.

@rukai rukai enabled auto-merge (squash) February 21, 2023 01:26
@rukai rukai merged commit 4e914ee into shotover:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbromhead benbromhead benbromhead approved these changes

@conorbros conorbros conorbros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rukai @benbromhead @conorbros